[Scummvm-tracker] [ScummVM :: Bugs] #13482: Improve "Maniac Mansion Deluxe" detection

[ScummVM :: Bugs]

#13482: Improve "Maniac Mansion Deluxe" detection
-------------------------+-------------------------------------------------
Reporter:                |      Owner:  (none)
  LukasThyWalls          |
    Type:  defect        |     Status:  new
Priority:  normal        |  Component:  Engine: AGS
 Version:                |   Keywords:  Manias Mansion Deluxe, AGS,
    Game:                |  Detection,
-------------------------+-------------------------------------------------
 Hello.

 "Maniac Mansion Deluxe" is still weirdly detecte by ScummVM (Tested with
 2.6.0git5613-g8f0da16853b)

 In all version i tested (1.0 and 1.4), ScummVM asks between ''Maniac
 Mansion Deluxe'' and ''Maniac Sports (Windows/English) - Unknown
 Variant'', and in the status window show the warning about unknown game
 variant of maniacsports-win:

 For Maniac Mansion Deluxe 1.0:
 {{{
 Matched game IDs for the director engine: maniacsports-win

   {"MANIAC.EXE", 0, "3128b9f90e2f954ba704414ae854d10b", 9395050},
 }}}

 For Maniac Mansion Deluxe 1.4
 {{{
 Matched game IDs for the director engine: maniacsports-win

   {"MANIAC.EXE", 0, "465f972675db2da6040518221af5b0ba", 10409172},
 }}}

 However, looking the code, i see the Maniac Sports for director have other
 data:

 https://github.com/scummvm/scummvm/blob/master/engines/ags/detection_tables.h#L5165
 {{{
 // Original Mac filename is Maniac Sports™
 MACGAME1("maniacsports", "", "Maniac Sports",
 "2ce360c9ea2da80a2c6d1040b0ad92dd", 421218, 311),
 WINGAME1("maniacsports", "", "MANIAC.EXE",
 "65d06b5fef155a2473434571aff5bc29", 371274, 311),
 }}}

 ... very different to the Maniac Mansion Deluxe ones:

 https://github.com/scummvm/scummvm/blob/master/engines/ags/detection_tables.h#L5165
 {{{
 GAME_ENTRY("maniacmansiondeluxe", "Maniac.exe",
 "3128b9f90e2f954ba704414ae854d10b", 9395050),  // v1.05
 GAME_ENTRY("maniacmansiondeluxe", "Maniac.exe",
 "465f972675db2da6040518221af5b0ba", 10181366), // v1.3
 GAME_ENTRY("maniacmansiondeluxe", "Maniac.exe",
 "465f972675db2da6040518221af5b0ba", 10409172),
 }}}

 So, i don't know why exactly the detection are confused between them,
 knowing there are others ''maniac.exe'' in the same AGS detection and in
 those case there isn't any confussion.

 Thanks.

 ----

 Also, there is a bunch of others games with similar issues there
 https://bugs.scummvm.org/ticket/13292
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13482>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM