[Scummvm-tracker] [ScummVM :: Bugs] #13432: GUI: Options dialog complains about non-existing saves in autosave slot

[ScummVM :: Bugs]

#13432: GUI: Options dialog complains about non-existing saves in autosave slot
-------------------------+--------------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Common
 Version:                |  Resolution:
Keywords:                |        Game:  Future Wars
-------------------------+--------------------------
Comment (by macca8):

 I’m not sure that this is an issue with the GUI (unless, of course, you’re
 referring to the text in the dialog), because the dialog is functioning as
 expected by recognizing an inappropriately named dummy autosave, then
 reporting it as a non-autosave saved game, which would otherwise block
 autosaving.

 Have you tested Future Wars to confirm that this dummy autosave
 description also triggers the in-game warning message when attempting an
 autosave?

 The underlying issue here is that this particular dummy autosave
 description doesn’t conform to the name-testing criteria as defined in
 hasAutosaveName(), which requires the case-sensitive “Autosave” string, or
 its translated equivalent, to be present in any valid autosave
 description, whether dummy or actual. For engines which don’t set their
 own, this defaults to “Autosave” in both cases.

 Furthermore, since the 2.5.1 release, hasAutosaveName() has been updated
 to allow for partial matching of the “Autosave” string (for example, if
 trimmed by an engine that imposes a limit on savename sizes). As a result,
 the “Autosave” string must be positioned at the beginning of any
 description which includes additional characters in the resulting savename
 (as is the case here).

 This “Empty autosave” description originates from the Cine engine, and can
 be found in two locations in engines/cine/metaengine.cpp: L151-154 (in
 listSaves()) & L214-216 (in querySaveMetaInfos()).

 In my opinion, the least disruptive solution here is to change this
 description from “Empty autosave” to “Autosave empty” or similar (or
 simply “Autosave”, which is the default for most games), which should
 remove the entry from this dialog, and avoid displaying the in-game
 warning when autosaving.

 Since there’s no evidence at this time that other engines are similarly
 affected, treating this as a one-off seems logical, so any further action
 should be unnecessary.

 As I’m an end user, please feel free to follow up this suggestion if you
 consider it worthwhile. Thanks for your time.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13432#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM