[Scummvm-tracker] [ScummVM :: Bugs] #13933: Use “Enable game-specific enhancements” for Sierra bug fixes

[ScummVM :: Bugs]

#13933: Use “Enable game-specific enhancements” for Sierra bug fixes
-------------------+--------------------------
Reporter:  obskyr  |       Owner:  (none)
    Type:  defect  |      Status:  new
Priority:  normal  |   Component:  Engine: SCI
 Version:          |  Resolution:
Keywords:          |        Game:
-------------------+--------------------------
Comment (by obskyr):

 Alright – script_patches.cpp can't simply be disabled. That's good to
 know! It's why I qualified that suggestion with a “perhaps”. I'm just a
 lowly user: unlike you, I don't know the codebase.

 But that's only to speak of game-breaking bugs and crashes. That's
 apparently not the extent of the changes – see, for example, the
 aforementioned Laura Bow bug. The fact remains that there's an “Enable
 game-specific enhancements” checkbox because people wanted behavior more
 like the originals. Sierra games should have that checkbox in the same way
 LucasArts games already do. Whatever line you draw there between “game-
 breaking bug fix” and “enhancement” isn't my business – make that judgment
 as you wish!

 Since it's all in this one file and limited to the SCI engine, it might
 not be as difficult to find the changes as I thought! Perhaps a pull
 request would be welcome? I'm envisioning adding a boolean “essential”
 flag (which signifies whether something is game-breaking or not) to each
 patch, and unchecking the “Enable game-specific enhancements” checkbox
 would then only disable  patches where it's set to `false`. I'd also
 update [https://wiki.scummvm.org/index.php?title=SCUMM/Game_Enhancements
 the wiki article] to reflect which patches are included.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13933#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM