[Scummvm-tracker] [ScummVM :: Bugs] #13933: Use “Enable game-specific enhancements” for Sierra bug fixes

[ScummVM :: Bugs]

#13933: Use “Enable game-specific enhancements” for Sierra bug fixes
-------------------+--------------------------
Reporter:  obskyr  |       Owner:  (none)
    Type:  defect  |      Status:  new
Priority:  normal  |   Component:  Engine: SCI
 Version:          |  Resolution:
Keywords:          |        Game:
-------------------+--------------------------

Old description:

> As of some recent version(s), bugs present in the original version of a
> variety of Sierra games were fixed in ScummVM, making their behavior
> different from the originals. Following the precedent set by
> [https://wiki.scummvm.org/index.php?title=SCUMM/Game_Enhancements&oldid=35577
> these LucasArts games,] these bug fixes should use the “Enable game-
> specific enhancements” setting.
>
> I don't know exactly which games are affected, but
> [https://www.benshoof.org/blog/super-sleuth this blog post] mentions
> “over one hundred original Sierra bugfixes” being added in version 2.1.0.
> It's probably possible to find the relevant games and changes by looking
> at the commits! It seems that most (if not all?) of the changes are in
> [https://github.com/scummvm/scummvm/blob/master/engines/sci/engine/script_patches.cpp
> /engines/sci/engine/script_patches.cpp] – perhaps this whole file can be
> disabled, rather than having to do it per enhancement.
>
> I've filed this ticket under “Engine: SCI”, but it might affect some AGI
> games as well.
>
> ----
>
> I'm not sure what the stated purpose of ScummVM is – I believe it's
> primarily to recreate these games so that they're accessible on modern
> platforms. Going back and changing their behavior, though, suggests that
> it might be something more akin to “making a better version of these
> games”. On the other hand, there's the aforementioned “Enable game-
> specific enhancements” checkbox, so it might be both!
>
> On a personal note, I use ScummVM for convenience, and bar concessions
> made for that convenience, want to experience these video games as they
> were to the extent that that's possible. For example, I recently played
> the MS-DOS version of ''The Colonel's Bequest'', and was disappointed to
> see [https://youtu.be/U2budy3S3MA?t=1834 the plane flying by], as opposed
> to the hilarious and charming bug that that makes a statue fly by in that
> version of the game.

New description:

 As of some recent version(s), bugs present in the original version of a
 variety of Sierra games were fixed in ScummVM, making their behavior
 different from the originals. Following the precedent set by
 [https://wiki.scummvm.org/index.php?title=SCUMM/Game_Enhancements&oldid=35577
 these LucasArts games,] these bug fixes should use the “Enable game-
 specific enhancements” setting.

 I don't know exactly which games are affected, but
 [https://www.benshoof.org/blog/super-sleuth this blog post] mentions “over
 one hundred original Sierra bugfixes” having been added as of version
 2.1.0. It's probably possible to find the relevant games and changes by
 looking at the commits! It seems that most (if not all?) of the changes
 are in
 [https://github.com/scummvm/scummvm/blob/master/engines/sci/engine/script_patches.cpp
 /engines/sci/engine/script_patches.cpp] – perhaps this whole file can be
 disabled, rather than having to do it per enhancement.

 I've filed this ticket under “Engine: SCI”, but it might affect some AGI
 games as well.

 ----

 I'm not sure what the stated purpose of ScummVM is – I believe it's
 primarily to recreate these games so that they're accessible on modern
 platforms. Going back and changing their behavior, though, suggests that
 it might be something more akin to “making a better version of these
 games”. On the other hand, there's the aforementioned “Enable game-
 specific enhancements” checkbox, so it might be both!

 On a personal note, I use ScummVM for convenience, and bar concessions
 made for that convenience, want to experience these video games as they
 were to the extent that that's possible. For example, I recently played
 the MS-DOS version of ''The Colonel's Bequest'', and was disappointed to
 see [https://youtu.be/U2budy3S3MA?t=1834 the plane flying by], as opposed
 to the hilarious and charming bug that that makes a statue fly by in that
 version of the game.

--
Comment (by obskyr):

 Replying to [comment:13 m-kiewitz]:
 > Replying to [comment:11 obskyr]:
 > > …Why are you going back and picking out random incidental things to
 argue against?
 >
 > That's a major part of ticket description, and I'm just saying that this
 part is factually wrong and a misunderstanding. That's all. Should
 probably get removed, it's not even really what this ticket is really
 about.

 Sure. I've changed it to “having been added as of” instead of “added in”.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13933#comment:14>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM