[Scummvm-tracker] [ScummVM :: Bugs] #13933: Use “Enable game-specific enhancements” for Sierra bug fixes

[ScummVM :: Bugs]

#13933: Use “Enable game-specific enhancements” for Sierra bug fixes
-------------------+--------------------------
Reporter:  obskyr  |       Owner:  bluegr
    Type:  defect  |      Status:  closed
Priority:  normal  |   Component:  Engine: SCI
 Version:          |  Resolution:  invalid
Keywords:          |        Game:
-------------------+--------------------------
Changes (by bluegr):

 * owner:  (none) => bluegr
 * status:  new => closed
 * resolution:   => invalid

Comment:

 The script patches we have created for the SCI engine are vastly different
 from the ones in the SCUMM engine, as almost all of them lead to game
 crashes, and are not cosmetic bugs.

 These patches have been created for the following reasons, among others:
 - To fix bugs that worked in Sierra SCI purely by accident
 - To fix script bugs that result in lockups, crashes or invalid game state
 - To fix timing bugs in game scripts that worked only in old PCs. Modern
 PCs that are much faster trigger all sorts of timing bugs
 - To fix serious bugs in unpatched game versions that were later fixed by
 Sierra, and result in crashing, lockups or unintended dead ends
 - To fix badly written scripts in fan games
 - To increase the number of allowed saved games
 - To fix compatibility with some fan patches (e.g. the fan made subtitle
 patch in GK2)
 - To fix missing points in some games, that were explicitly mentioned in
 the official Sierra walkthroughs (e.g. in LSL2)
 - Add functionality for simultaneous speech + subtitles
 - Disable the change directory button in original save/load dialogs (we
 place all saved games in the same folder)

 Of course, there are tons of script patches, and some which belong to
 other categories that I may have missed.

 NONE of the above fixes change the way the actual games work. None can be
 toggled by the user, as disabling any of these patches would crash the
 game. It doesn't make sense to disable any of the patches. In this bug, a
 single easter egg is referenced, which was initially implemented
 incorrectly, and later fixed. There is no point in allowing the user to
 toggle the bad implementation, just to see a flying statue instead of an
 airplane.

 So, to sum up: we can't, and won't allow toggling of the patches that are
 implemented in the SCI engine, as almost all of them lead to crashes,
 lockups and unintended dead ends. The only ones which would be considered
 as toggleable in the future are the fixes which would change the way the
 games are played. To my knowledge, we have no such fixes up to now. In the
 future, if we have such patches, we will consider to allow users to toggle
 them.

 Thus, for now, this discussion doesn't lead anywhere: we have closed
 multiple game bugs, and we don't want to allow users to re-enable them,
 thus I'm closing this bug as invalid. If there is a compelling reason to
 discuss or toggle specific script patches that we do in the SCI engine,
 feel free to open a feature request.

 Closing as invalid
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13933#comment:18>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM