[Scummvm-tracker] [ScummVM :: Bugs] #12832: DIRECTOR: Missing music cue in Spaceship Warlock intro

[ScummVM :: Bugs]

#12832: DIRECTOR: Missing music cue in Spaceship Warlock intro
-------------------------+--------------------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: Director
 Version:                |  Resolution:
Keywords:                |        Game:  Spaceship Warlock
-------------------------+--------------------------------
Comment (by eriktorbjorn):

 I'm not sure, but I think this is the commit that fixed it in the Windows
 version:

 {{{
 f48dbb43b6b6483ef2160ae3d087eb2e0f06c7e5 is the first new commit
 commit f48dbb43b6b6483ef2160ae3d087eb2e0f06c7e5
 Author: Scott Percival <code at moral.net.au>
 Date:   Sun Jul 31 19:00:13 2022 +0800

     DIRECTOR: Use LoopableAudioStream for score audio loops

     For looping sounds, the original code polled the score and created a
 new
     AudioStream every time the previous iteration finished playing. The
     downside of this approach is the sound needs to be fully resampled and
     buffered after each playback, which can be heard as a gap between
 loops.

     To fix this, loops now use a LoopableAudioStream. The reason why the
     previous code did not was to allow for a specific edge case.
     In Director, when a looping audio channel is set to cast member 0, the
     loop is allowed to finish the current iteration before the audio
 stops.
     Originally there wasn't a way of doing that, but now the
     LoopableAudioStream classes can stop playing after a number of
     iterations. As such, we keep a copy of the LoopableAudioStream handle
     and call for the loop to stop when the cast member gets set to 0.

     Improves looped audio playback in Eastern Mind.

     Fixes the guitar solo between the transition from BLAST.DXR to
 INTRO.DXR
     in Meet MediaBand.

     Fixes the audio transition between n.am and s.am in Meet MediaBand.

  engines/director/sound.cpp | 58
 +++++++++++++++++++++++++---------------------
  engines/director/sound.h   |  7 +++++-
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12832#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM