[Scummvm-tracker] [ScummVM :: Bugs] #13784: GRIM: Run-Time Check Failure #3

[ScummVM :: Bugs]

#13784: GRIM: Run-Time Check Failure #3
--------------------+----------------------------------------
Reporter:  henke37  |       Owner:  (none)
    Type:  defect   |      Status:  new
Priority:  normal   |   Component:  Engine: Grim
 Version:           |  Resolution:
Keywords:           |        Game:  Escape from Monkey Island
--------------------+----------------------------------------
Comment (by dwatteau):

 Does the following change make a difference?

 {{{
 diff --git a/engines/grim/lua/lstx.cpp b/engines/grim/lua/lstx.cpp
 index ab99141a971..c3fae583d6a 100644
 --- a/engines/grim/lua/lstx.cpp
 +++ b/engines/grim/lua/lstx.cpp
 @@ -1068,8 +1068,16 @@ yydefault:
         /* Do a reduction.  yyn is the number of a rule to reduce with.
 */
  yyreduce:
         yylen = yyr2[yyn];
 -       if (yylen > 0)
 -               yyval = yyvsp[1 - yylen]; /* implement default value of
 the action */
 +
 +       /* If YYLEN is nonzero, implement the default value of the action:
 +          `$$ = $1'.
 +
 +          Otherwise, the following line sets YYVAL to the semantic value
 of
 +          the lookahead token.  This behavior is undocumented and Bison
 +          users should not rely upon it.  Assigning to YYVAL
 +          unconditionally makes the parser a bit smaller, and it avoids a
 +          GCC warning that YYVAL may be used uninitialized.  */
 +       yyval = yyvsp[1-yylen];

         switch (yyn) {

 }}}

 From Bison 1.28c, 2000-10-02:
 https://git.savannah.gnu.org/cgit/bison.git/commit/?id=da9abf4366d824a23da3d2416856e9a482794eb1
 (since our lstx.cpp was made with the ancient GNU Bison 1.25).
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13784#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM