[Scummvm-tracker] [ScummVM :: Bugs] #12363: MYST3: Manually overwriting Autosave file disables autosaving.

[ScummVM :: Bugs]

#12363: MYST3: Manually overwriting Autosave file disables autosaving.
-------------------+----------------------------
Reporter:  macca8  |       Owner:  macca8
    Type:  defect  |      Status:  new
Priority:  normal  |   Component:  Engine: Myst3
 Version:          |  Resolution:
Keywords:          |        Game:  Myst 3: Exile
-------------------+----------------------------
Changes (by macca8):

 * status:  closed => new
 * resolution:  fixed =>

Comment:

 This bug has been reinstated in Myst III following the change in
 [https://github.com/scummvm/scummvm/commit/9b05c206993d3107f98ac5b437801e33ba3c79b7
 9b05c206], which reverted the autosave test in saveAutosaveIfEnabled()
 from hasAutosaveName() back to isAutosave().
 Also applies to any other game which has write access in the Autosave
 slot, and which sets the _saveType value based on the autosave flag (in my
 case, this also includes Riven).

 Currently, if a game specifically sets the _saveType value, there's no way
 to access the name test from within isAutosave(), and so in this case, the
 autosave file is incorrectly detected as a regular save (and triggers the
 in-game warning dialog), whereas previously, the same file was correctly
 detected as the autosave file, by using the name test exclusively.

 I have proposed a solution in #13842 which resolves this issue, by
 ensuring that if the autosave file fails either test (name or saveType),
 then the alternate test is also considered, thus avoiding what is in
 reality a false positive.

 I'm reopening this ticket, pending one of the team implementing #13842 or
 similar.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12363#comment:6>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM