[Scummvm-tracker] [ScummVM :: Bugs] #13432: GUI: Options dialog complains about non-existing saves in autosave slot

[ScummVM :: Bugs]

#13432: GUI: Options dialog complains about non-existing saves in autosave slot
-------------------------+--------------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Common
 Version:                |  Resolution:
Keywords:                |        Game:  Future Wars
-------------------------+--------------------------
Comment (by macca8):

 While the subject of this report targets the GUI, I believe the issue is
 restricted to the CINE engine.

 The issue regarding the invalid _saveType calculation is resolved by
 [https://github.com/scummvm/scummvm/pull/4393 PR4393], which includes
 reinstating the setAutosave(true) call that was previously removed from
 the CINE engine. This properly identifies the dummy autosave as an
 autosave, which resolves this issue.

 However, I don't believe that the dummy autosave should have been tested
 in the first place, since there's no saved game file attached to the
 entry. Currently, the CINE engine creates the dummy autosave in both its
 listSaves() & querySaveMetaInfos() methods. Normal practice is to include
 it only in the listSaves() method.

 IMHO, the correct procedure is to remove the dummy autosave call from its
 querySaveMetaInfos() method, but someone familiar with the CINE engine
 needs to confirm that this call hasn't been placed here for some other
 obscure reason.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13432#comment:9>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM