[Scummvm-tracker] [ScummVM :: Bugs] #14255: GLK: SCOTT: Hulk: "System messages" not shown

[ScummVM :: Bugs]

#14255: GLK: SCOTT: Hulk: "System messages" not shown
-----------------------+---------------------------------
Reporter:  angstsmurf  |       Owner:  (none)
    Type:  defect      |      Status:  new
Priority:  normal      |   Component:  Engine: GLK: Scott
 Version:              |  Resolution:
Keywords:              |        Game:
-----------------------+---------------------------------
Description changed by angstsmurf:

Old description:

> In Questprobe featuring the Hulk, many "systems messages" (those common
> to all ScottFree games) such as "TELL ME WHAT TO DO" and "I'm in a " are
> not displayed.
>
> There is some kind of memory corruption here, because when I tried to
> debug this by outputting all systems messages to the console as warnings,
> they suddenly started working just fine.
>
> The messages are assigned to the Common::StringArray `_sys` in `Globals`
> at line 141 of `load_game.cpp`:
>
> https://github.com/scummvm/scummvm/blob/0be224bd5b949ee37ba3d68b3d04eec9c801b272/engines/glk/scott/load_game.cpp#L141
>
> They are pointers to the array of const char `g_sysDictZX` defined at
> line 266 in ´game_info.cpp`:
>
> https://github.com/scummvm/scummvm/blob/0be224bd5b949ee37ba3d68b3d04eec9c801b272/engines/glk/scott/game_info.cpp#L226
>
> EDIT: And explanation for this bug, and a fix:
> https://github.com/scummvm/scummvm/pull/4728.

New description:

 In Questprobe featuring the Hulk, many "systems messages" (those common to
 all ScottFree games) such as "TELL ME WHAT TO DO" and "I'm in a " are not
 displayed.

 There is some kind of memory corruption here, because when I tried to
 debug this by outputting all systems messages to the console as warnings,
 they suddenly started working just fine.

 The messages are assigned to the Common::StringArray `_sys` in `Globals`
 at line 141 of `load_game.cpp`:

 https://github.com/scummvm/scummvm/blob/0be224bd5b949ee37ba3d68b3d04eec9c801b272/engines/glk/scott/load_game.cpp#L141

 They are pointers to the array of const char `g_sysDictZX` defined at line
 266 in ´game_info.cpp`:

 https://github.com/scummvm/scummvm/blob/0be224bd5b949ee37ba3d68b3d04eec9c801b272/engines/glk/scott/game_info.cpp#L226

 EDIT: An explanation for this bug, and a fix:
 https://github.com/scummvm/scummvm/pull/4728.

--
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14255#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM