[Scummvm-tracker] [ScummVM :: Bugs] #14025: Broken Sword 1 & 2 pretends to be 640x480 but it is never initialized / updated as such

[ScummVM :: Bugs]

#14025: Broken Sword 1 & 2 pretends to be 640x480 but it is never initialized /
updated as such
---------------------------+--------------------------------
Reporter:  mikrosk         |      Owner:  (none)
    Type:  defect          |     Status:  new
Priority:  normal          |  Component:  Engine: Sword1
 Version:                  |   Keywords:  resolution, height
    Game:  Broken Sword 1  |
---------------------------+--------------------------------
 The core bug is that the game is *not* 480 rows tall, it is always 400.
 But the engine for some reason initializes it to 480, since its first
 commit (oversight?)

 Then however, it is never initialized like that. So the first
 copyRectToScreen() I see is: 0, 40, 640, 400, i.e. it correctly updates
 the active part (good) but it can't be bothered to at least clear the top
 and bottom bars.

 Another annoyance is that on an 8-bit palette-based screen the top/bottom
 bars mimic the black colour so if there is a fading happening (like in the
 beginning of the game), the bars change color as well.

 So an easy fix would be to at least fix the bars init, the proper fix
 would be to change all the hardcoded constants to respect the game's
 original height and that is 400 rows.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14025>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM