[Scummvm-tracker] [ScummVM :: Bugs] #14542: SWORD1: Subtitle-only languages cannot be selected in 2.7.0

[ScummVM :: Bugs]

#14542: SWORD1: Subtitle-only languages cannot be selected in 2.7.0
-----------------------+-----------------------------
Reporter:  vpelletier  |       Owner:  (none)
    Type:  defect      |      Status:  new
Priority:  normal      |   Component:  Engine: Sword1
 Version:              |  Resolution:
Keywords:              |        Game:
-----------------------+-----------------------------
Comment (by antoniou79):

 I can reproduce this with ScummVM 2.8git and 2.7.0 on Windows 10 with the
 Steam version of the Broken Sword 1 (Original, provided as DLC) and the
 GOG version as well.

 I wonder if this applies to all of the versions of Broken Sword, ie. being
 able to provide subtitles for these languages regardless of the official
 localization of each version.

 A few extra observations:
 - The languages that seem to be included (text only), are: English,
 French, Italian, German, Spanish, Brazilian Portuguese, Czech.
 - It seems like ScummVM uses hardcoded text for the Menu options for these
 languages (see:
 https://github.com/scummvm/scummvm/blob/deb8317c206b8742a17736a1a1652557779b39c0/engines/sword1/control.cpp#L1466).
 It also seems that a few of those texts are left untranslated (in English)
 eg. "Start" (for German and Czech) or "Text" (for "German")
 - Adding multiple copies of the segments for detection of the Steam
 (Anniversary Re-release) and GOG versions, only changing the language to
 one of the above seems to work, and the "--language=" command line (or
 configuration key in scummvm.ini) starts working too. The changes I made
 were in engines\sword1\detection_tables.h, copying the segments:
 https://github.com/scummvm/scummvm/blob/deb8317c206b8742a17736a1a1652557779b39c0/engines/sword1/detection_tables.h#L128
 and
 https://github.com/scummvm/scummvm/blob/deb8317c206b8742a17736a1a1652557779b39c0/engines/sword1/detection_tables.h#L154
 - Since the movie cutscenes do not have subtitles (unless the ScummVM
 addon for subtitles is "installed"), this "feature" could cause confusion
 to an end user (eg. choosing French as the language and then starting the
 game with English voiceover and no text).

 Others things to consider:
 - Does this also happen for Broken Sword 2?
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14542#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM