[Scummvm-tracker] [ScummVM :: Bugs] #14435: SHERLOCK: ROSETATTOO: Unable to proceed in Case of the Rose Tattoo, Wiggins do not present correct alt.

[ScummVM :: Bugs]

#14435: SHERLOCK: ROSETATTOO: Unable to proceed in Case of the Rose Tattoo, Wiggins
do not present correct alt.
-------------------------------------+-------------------------------------
Reporter:  VonKossa                  |       Owner:  (none)
    Type:  defect                    |      Status:  new
Priority:  normal                    |   Component:  Engine: Sherlock
 Version:                            |  Resolution:
Keywords:  Sherlock Wiggins case,    |        Game:  Sherlock Holmes: Case
  Rose Tattoo                        |  of the Rose Tattoo
-------------------------------------+-------------------------------------
Comment (by PushmePullyu):

 I did some more testing and found something that might have caused the
 problem:
 It seems that triggers created via TattooTalk::cmdSetSceneEntryFlag() can
 be lost when loading a save.
 These are stored in Common::Array<Sherlock::Tattoo::SceneTripEntry>
 Sherlock::Tattoo::TattooScene::_sceneTripCounters and are neither synced
 nor reset when restoring.

 Testing was done with master !deb8317c206b8742a17736a1a1652557779b39c0.

 To reproduce:
 1. Load attached save (created just after finishing the Needhem scene at
 Cleopatra's Needle)
 2. Verify flag 897 is clear in debug console (CTRL+ALT+D then type: flag
 897)
 3. Exit the scene to the city map (exit is in the top left)
 4. Go to 221B Baker Street (this will create a SceneTripEntry)
 5. Save the game in a new slot
 6. Verify flag 897 is still clear
 7. Exit the scene to the city map
 8. Go to 221B Baker Street again
 9. Verify flag 897 is now set (due to the SceneTripEntry)
 10. Load the save created in step 5
 11. Exit 221B Baker street to the city map
 12. Go to 221B Baker street again
 13. Check flag 897
 The flag should be clear now, since the _sceneTripCounters array was not
 synced.

 I have a fix for this almost ready (it will require a save version bump
 unfortunately) and will open a PR soon.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14435#comment:7>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM