[Scummvm-tracker] [ScummVM :: Bugs] #14558: SCI: Use the SCI32 SOL decoder for SCI 0-1.1 games

[ScummVM :: Bugs]

#14558: SCI: Use the SCI32 SOL decoder for SCI 0-1.1 games
------------------------+--------------------------
Reporter:  ccawley2011  |       Owner:  (none)
    Type:  defect       |      Status:  new
Priority:  normal       |   Component:  Engine: SCI
 Version:               |  Resolution:
Keywords:  performance  |        Game:
------------------------+--------------------------
Comment (by sluicebox):

 Notes:

 - SCI16 handles a SOL header format in QFG3 Demo (according to the
 comment), I assume the SCI32 code doesn't
 - SCI16 handles SOL flags that SCI32 doesn't and vice versa
 - SCI32 code makes audio decoding decisions based on interpreter runtime,
 those will need to be audited for SCI16 compatibility
 - SCI16 indeed decompresses SOLs up front, requiring a buffer twice the
 size of the SOL. Even with this change, the SOL will still require a
 buffer to be copied to for playback, but it would be half the current
 size. See comments in `AudioPlayer::getAudioStream` and
 df4bf9d5571fbffae88323c62469900c24b159a0

 This would be a good change to eliminate the duplicate code. It looks like
 you'd have to adapt the SCI32 code to support all the SCI16 SOL versions.
 I don't know how many SOL versions are out there or in what games, but
 you'd want to find and test them all. I didn't know what "SOL" was until
 today, so I'm not exactly volunteering. =)
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14558#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM