[Scummvm-tracker] [ScummVM :: Bugs] #14500: Secret of Monkey Island EGA LRG Crash

[ScummVM :: Bugs]

#14500: Secret of Monkey Island EGA LRG Crash
------------------------+------------------------------
Reporter:  Bartman3010  |       Owner:  (none)
    Type:  defect       |      Status:  new
Priority:  normal       |   Component:  Engine: SCUMM
 Version:               |  Resolution:
Keywords:               |        Game:  Monkey Island 1
------------------------+------------------------------
Comment (by dwatteau):

 So yes, it's not only 903.LFL and DISK04.LEC, but Limited Run Games
 provided a faulty DISK03.LEC file too.

 Costume 11 (the monkeys under the wedding dress) in room 78 appears to be
 corrupted in this dump, comparing it with the one from my original French
 EGA CD:

 {{{
 Full SHA-1 sum                           | Resource
 -----------------------------------------|------------------------------------
 34faaa40f4e445029b1cb3c3ecfa50ff1d2652ea | MONKEY1_EGA_FR/LF_0078-CO_0011
 6400546f3a1f2d2ff3b1fe2d24e73fc6c732a232 |
 MONKEY1_EGA_EN_LRG/LF_0078-CO_0011
 }}}

 The faulty resource triggers a heap buffer-overflow in
 `Scumm::BaseCostumeRenderer::skipCelLines` (as triggered by
 AddressSanitizer) otherwise, since this costume has invalid data. Other
 resources embedded inside DISK03.LEC could be impacted as well.

 Fortunately, you can still recover what appears to be a valid DISK03.LEC
 file from the KryoFlux dumps, if you run a similar `dtc` command from the
 `mi1_dos_525_disk3` resources:

 {{{
 cd mi1_dos_525_disk3
 dtc -ftrack00.0.raw -i0 -k2 -fnewdisk3.img -i4 -m1 -l1
 }}}

 and then mount or extract the resulting `newdisk3.img` image, in order to
 grab its DISK03.LEC resource. The game appears to run fine once you do
 that.

 I'll update the detection code in ScummVM so that people will know that
 this DISK03.LEC file from this release needs to be recreated from the
 KryoFlux dumps as well.

 I'll amend my guide at <https://dwatteau.github.io/scummfixes/corrupted-
 monkey1-ega-files-limitedrungames.html> for this. Thank you very much for
 reporting this, and sorry for not checking this copy of the game until the
 very end!
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14500#comment:4>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM