[Scummvm-tracker] [ScummVM :: Bugs] #12329: BACKENDS: IOS: MP3 playback failing, libmad writing out of bounds

[ScummVM :: Bugs]

#12329: BACKENDS: IOS: MP3 playback failing, libmad writing out of bounds
----------------------+-----------------------------
Reporter:  sluicebox  |       Owner:  larsamannen
    Type:  defect     |      Status:  closed
Priority:  high       |   Component:  Port: iOS
 Version:             |  Resolution:  fixed
Keywords:             |        Game:  King's Quest 6
----------------------+-----------------------------
Changes (by sluicebox):

 * owner:  (none) => larsamannen
 * status:  new => closed
 * resolution:   => fixed

Comment:

 Closing this as fixed, I can now KQ6 in peace. Thank you larsamannen!

 carlo-bramini: I'm sure everyone on the team would be receptive to using a
 more maintained mp3 library. PRs welcome!

 Take this ticket, for example. We knew what the problem was from the
 start, that we "just" needed to build a popular library correctly for this
 popular platform, and it still took two years. Because we "just" needed
 someone who had the skill, and had the time, and had the interest. In
 other words, the three hardest parts. =)

 I don't know if you've taken a look at the ScummVM code that interacts
 with libmad, but  to me, it's a nontrivial amount. And it's from 20 years
 ago. I would expect that rewriting all of that would require knowledge in
 both libraries, in addition to audio expertise. Also, the new library must
 work on every single platform that the old one does. All so that mp3
 playback keep working with no perceptable difference. (No one will notice
 a theoretical playback quality difference of mp3s during adventure games.)
 Who would volunteer for that task? Sounds much harder than this, and this
 took two years. PRs welcome!

 Also, if the standard is "avoid third party libraries that requires
 platform specific header patches"... I have some really bad news for you
 about C++... https://github.com/scummvm/dockerized-
 bb/tree/master/toolchains

 I just want it clear that the obstacles to switching libraries don't
 include lack of consideration. Speaking for myself, it looks hard. I could
 be happily proven wrong with a PR! I'll check back on this ticket in a few
 years and see. =)
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12329#comment:10>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM