[Scummvm-tracker] [ScummVM :: Bugs] #13908: SCUMM: INDY3 (MAC): ASAN crash in Player_V2Base::next_freqs() in Castle Brunwald

[ScummVM :: Bugs]

#13908: SCUMM: INDY3 (MAC): ASAN crash in Player_V2Base::next_freqs() in Castle
Brunwald
-------------------------------------------------+-------------------------
Reporter:  dwatteau                              |       Owner:  (none)
    Type:  defect                                |      Status:  new
Priority:  high                                  |   Component:  Engine:
                                                 |  SCUMM
 Version:                                        |  Resolution:
Keywords:  asan,crash,castle brunwald,macintosh  |        Game:  Indiana
                                                 |  Jones 3
-------------------------------------------------+-------------------------
Comment (by bluegr):

 Replying to [comment:7 eriktorbjorn]:
 > Which means that there is no chance that freqmod_modulo will be able to
 keep up:
 >
 > {{{
 >       channel->d.freqmod_offset += channel->d.freqmod_incr;
 >       if (channel->d.freqmod_offset > channel->d.freqmod_modulo)
 >               channel->d.freqmod_offset -= channel->d.freqmod_modulo;
 > }}}
 >
 > Perhaps this should be changed to
 >
 > {{{
 >       channel->d.freqmod_offset += channel->d.freqmod_incr;
 >       if (channel->d.freqmod_offset > channel->d.freqmod_modulo)
 >               channel->d.freqmod_offset -= channel->d.freqmod_modulo;
 > }}}
 >

 Is it me, or is there no change between these two code snippets?
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13908#comment:8>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM