[Scummvm-tracker] [ScummVM :: Bugs] #14159: GRIM: MD5 dialog can’t be cancelled

[ScummVM :: Bugs]

#14159: GRIM: MD5 dialog can’t be cancelled
------------------------+---------------------------
Reporter:  ccawley2011  |       Owner:  (none)
    Type:  defect       |      Status:  new
Priority:  high         |   Component:  Engine: Grim
 Version:               |  Resolution:
Keywords:               |        Game:
------------------------+---------------------------
Comment (by deckarep):

 Hi ScummVM Team,

 I was looking at this bug to see if I can contribute a patch to improve it
 and I discovered that one of the reasons the md5 detection code for the
 GRIM engine is slow is that it's doing an md5 checksum of the full file
 (all bytes).

 However,

 It seems like somewhere Grim is supposed to check only 5k bytes per this
 function:

 ./scummvm --md5 --md5-path=<file> --md5-engine=grim

 Notice the output says:
 VOX0001.LAB: <hash> (first 5000 bytes), <size> bytes

 Since Grim has a lot of files with some being quite large to check for it
 might be good to modify this related code to cap all md5 checks at 5k
 bytes to speed up this process for end users.

 I'm not sure why there's an inconsistency here but there is a potential
 for this md5 integrity check code to be much faster.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14159#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM