[Scummvm-tracker] [ScummVM :: Bugs] #14601: ACCESS: File not closed after exit (Guardians of Eden)

[ScummVM :: Bugs]

#14601: ACCESS: File not closed after exit (Guardians of Eden)
------------------------------+----------------------------------------
Reporter:  GandalfTheWhite80  |       Owner:  (none)
    Type:  defect             |      Status:  new
Priority:  normal             |   Component:  Engine: Access
 Version:                     |  Resolution:
Keywords:                     |        Game:  Amazon: Guardians of Eden
------------------------------+----------------------------------------
Comment (by PushmePullyu):

 Thanks for the report!

 This seems to be a file handle leak caused by the following code:
 in engines/access/amazon/amazon_logic.cpp:
 in void CampScene::mWhileDoOpen():

 {{{
 if (_vm->_conversation != 2) {
                 // Cutscene at start of chapter 1
                 screen.setPanel(3);
                 _vm->startChapter(1); // <--------- this calls
 loadEstablish(int)
                 _vm->establishCenter(0, 1); // <--- this also calls
 loadEstablish(int)
         }
 }}}


 The first call to loadEstablish() assigns a new Resource to
 Access::Resource *Access::AccessEngine::_establish. This resource holds a
 file handle for "ETEXT1.DAT".
 The second call now reassigns to _establish, so the Resource it pointed to
 previously is lost, including the file handle.

 PR with fix is here: https://github.com/scummvm/scummvm/pull/5310
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14601#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM