[Scummvm-tracker] [ScummVM :: Bugs] #14621: SCUMM: VAR_VIDEOMODE warning when loading savegames for HE version 70

[ScummVM :: Bugs]

#14621: SCUMM: VAR_VIDEOMODE warning when loading savegames for HE version 70
---------------------------------------+---------------------------
Reporter:  eriktorbjorn                |      Owner:  (none)
    Type:  defect                      |     Status:  new
Priority:  normal                      |  Component:  Engine: SCUMM
 Version:                              |   Keywords:
    Game:  Putt-Putt Joins the Parade  |
---------------------------------------+---------------------------
 I made a savegame for Putt-Putt Joins the Parade. (Very early in the game,
 so I see no need to attach it.) When I loaded it, I got the following
 warning:

 {{{
 WARNING: Loading savegame with a different render mode setting. Glitches
 might occur!
 }}}

 The game is version 6, HE version 70. That should mean it runs on an
 instance of ScummEngine_v70he. That means setupScummVars() will set up
 VAR_VIDEOMODE to be variable number 49. (In later HE versions, I think
 it's not used.)

 However, resetScummVars() will only initialize VAR(VAR_VIDEOMODE) for
 games where the HE version is ''less'' than 70. So when
 saveLoadWithSerializer() calls setVideoModeVarToCurrentConfig(), it's
 likely to change the value of VAR(VAR_VIDEOMODE) thus triggering the
 warning.

 I'm guessing the error is that the game gets a VAR_VIDEOMODE variable,
 because it doesn't seem possible to change the rendering mode for the
 game. But I don't dare to change this because a) I'm not sure, and b) if
 I'm right, are there other variables that the game also shouldn't have but
 that it inherits from earlier SCUMM versions? How serious would that be?
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14621>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM