[Scummvm-tracker] [ScummVM :: Bugs] #14616: SCUMM: FT: Crash with Assertion Fail when riding the bike for the first time

[ScummVM :: Bugs]

#14616: SCUMM: FT: Crash with Assertion Fail when riding the bike for the first
time
-----------------------------------+----------------------------
Reporter:  antoniou79              |       Owner:  (none)
    Type:  defect                  |      Status:  new
Priority:  normal                  |   Component:  Engine: SCUMM
 Version:                          |  Resolution:
Keywords:  crash, acos, assertion  |        Game:  Full Throttle
-----------------------------------+----------------------------
Comment (by eriktorbjorn):

 I tried bisecting the Full Throttle crash (before hearing that someone
 else already might have done so), and landed on this commit:

 {{{
 8a54e258a5aeac082ebb3a444d0c57138b6694f0 is the first bad commit
 commit 8a54e258a5aeac082ebb3a444d0c57138b6694f0
 Author: athrxx <athrxx at scummvm.org>
 Date:   Sun Aug 27 02:08:52 2023 +0200

     SCUMM: (SCUMM7/8) - fix actor turning animation

     The turning interpolation was completely disabled for v7/8, since it
     interfered with DIG walk scripts. The result was that DIG was the only
     v7/8 game that still had (script controlled) turning animations. COMI
     and FT don't use walk scripts. So the actors would just flip directly
 from
     the current facing direction to the target facing.

     I have now changed parts of the walking code (and some other parts)
     to better match the original v7/8 code.

  engines/scumm/actor.cpp      | 342
 +++++++++++++++++++++----------------------
  engines/scumm/actor.h        |  17 ++-
  engines/scumm/akos.h         |   2 +-
  engines/scumm/base-costume.h |   2 +-
  engines/scumm/script_v6.cpp  |   4 +-
  engines/scumm/script_v8.cpp  |   4 +-
  engines/scumm/scumm.cpp      |   2 +
  engines/scumm/util.cpp       |   6 +-
  engines/scumm/util.h         |   2 +-
  9 files changed, 200 insertions(+), 181 deletions(-)
 }}}

 Does that make sense?
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14616#comment:4>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM