[Scummvm-tracker] [ScummVM :: Bugs] #14646: SCI: QFG4: Game crashes if Import character button is clicked without a file selected

[ScummVM :: Bugs]

#14646: SCI: QFG4: Game crashes if Import character button is clicked without a
file selected
-------------------------+--------------------------------
Reporter:  KGOrphanides  |       Owner:  sluicebox
    Type:  defect        |      Status:  closed
Priority:  normal        |   Component:  Engine: SCI
 Version:                |  Resolution:  fixed
Keywords:  QFG4, import  |        Game:  Quest for Glory 4
-------------------------+--------------------------------
Changes (by sluicebox):

 * owner:  (none) => sluicebox
 * status:  new => closed
 * resolution:   => fixed

Comment:

 Fixed in:
 https://github.com/scummvm/scummvm/commit/2a9439182a1a06c9400689be395af14c4f6e42a3

 This *should* have been a fatal error in Sierra's interpreter, in which
 case someone would have noticed it and fixed the game script, but
 according to the disassembly, the interpreter's validation tested the
 address that held the null pointer instead of the null pointer itself, so
 the validation always passed. Classic QFG4! =)

 I've updated our validation to match what really happens.

 Thanks again!
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14646#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM