[Scummvm-tracker] [ScummVM :: Bugs] #1675: INDY3VGA: Lockup during conversation with drunken nazi

[ScummVM :: Bugs]

#1675: INDY3VGA: Lockup during conversation with drunken nazi
-------------------------+------------------------------
Reporter:  SF/sgt-nukem  |       Owner:  fingolfin
    Type:  defect        |      Status:  closed
Priority:  normal        |   Component:  Engine: SCUMM
 Version:                |  Resolution:  fixed
Keywords:                |        Game:  Indiana Jones 3
-------------------------+------------------------------
Comment (by dwatteau):

 In [changeset:"853c0a989417f547738529218d572fc74e433959" 853c0a98]:
 {{{#!CommitTicketReference repository=""
 revision="853c0a989417f547738529218d572fc74e433959"
 SCUMM: Improve Trac#1675 and Trac#2715 bugfixes for German Indy3

 - Fix an off-by-one in resStrLen() return value, and apply its workaround
   for Trac#2715 too.
 - Merge the two convertMessageToString() workarounds into a single one,
   and fix another off-by-one in the Trac#1675 case.
 - Restrict both workarounds to the German release of Indy3 (DOS release
   checked against my own copy, Amiga release tested by gabberhead).
 - Restrict both workarounds to the two rooms using the wrong byte for the
   German Eszett character -- but don't limit it to a particular script
   number, because the faulty lines can be triggered by some global scripts
   too (e.g. highlighting a dialogue option).

 This should fix the following problems:

 - the use-case in Trac#2715 still triggering a fatal "string escape
   sequence 32 unknown" error in convertMessagetoString(), when one
   highlights the "Woher weiß ich, daß SIE kein Spion sind?" line.
 - the missing full stop at the end of the "…irgendwo hier im
   Schloß." line from the drunk guard.
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/1675#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM