[Scummvm-tracker] [ScummVM :: Bugs] #15303: SCI: LSL5: Timed message skipped during LSL5 coffee scene (symptom of a bigger problem?)

[ScummVM :: Bugs]

#15303: SCI: LSL5: Timed message skipped during LSL5 coffee scene (symptom of a
bigger problem?)
-------------------------+-----------------------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: SCI
 Version:                |  Resolution:
Keywords:                |        Game:  Leisure Suit Larry 5
-------------------------+-----------------------------------
Comment (by eriktorbjorn):

 I've attached a second attempt at the patch. I thought the initial `push0`
 wasn't related to the subsequent `callk`, but I guess it is?

 So I had to shave off yet another byte by using a `jmp` to some common
 code.

 It seems to be working, but I should stress that this is very much just
 intended as a proof-of-concept. It's not intended for merging!

 This is what my patched version of the script looks like:

 {{{
 0032:064b: 0x76,                                // push0
 ; species
 0032:064c: 0x43, 0x42, 0x00,                    // callk
 GetTime[42],   00
 0032:064f: 0x36,                                // push
 0032:0650: 0x63, 0x5c,                          // pToa         ticks[5c]
 0032:0652: 0x04,                                // sub
 0032:0653: 0x36,                                // push
 0032:0654: 0x35, 0x00,                          // ldi          00
 0032:0656: 0x1e,                                // gt?
 0032:0657: 0x31, 0x07,                          // bnt          07  [0660]
 0032:0659: 0x39, 0x6c,                          // pushi        6c
 ; 108, 'l', dispose
 0032:065b: 0x78,                                // push1
 ; superClass
 0032:065c: 0x67, 0x5e,                          // pTos
 disposeWhenDone[5e]
 0032:065e: 0x33, 0x14,                          // jmp          14  [0674]
 0032:0660: 0x63, 0x58,                          // pToa         eyes[58]
 0032:0662: 0x31, 0x07,                          // bnt          07  [066b]
 0032:0664: 0x38, 0xb0, 0x00,                    // pushi        00b0
 ; 176, cycle
 0032:0667: 0x78,                                // push1
 ; superClass
 0032:0668: 0x36,                                // push
 0032:0669: 0x54, 0x06,                          // self         06
 0032:066b: 0x63, 0x5a,                          // pToa         mouth[5a]
 0032:066d: 0x31, 0x07,                          // bnt          07  [0676]
 0032:066f: 0x38, 0xb0, 0x00,                    // pushi        00b0
 ; 176, cycle
 0032:0672: 0x78,                                // push1
 ; superClass
 0032:0673: 0x36,                                // push
 0032:0674: 0x54, 0x06,                          // self         06
 0032:0676: 0x48,                                // ret
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15303#comment:40>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM