[Scummvm-tracker] [ScummVM :: Bugs] #15341: GOB2: footsteps sound issues

[ScummVM :: Bugs]

#15341: GOB2: footsteps sound issues
-----------------------+--------------------------
Reporter:  DisizDream  |       Owner:  bluegr
    Type:  defect      |      Status:  closed
Priority:  high        |   Component:  Engine: Gob
 Version:              |  Resolution:  fixed
Keywords:              |        Game:  Gobliins 2
-----------------------+--------------------------
Comment (by Antonin-Carette-RedArtGames):

 This ticket should be closed as the issue is not fixed.

 This ticket actually describes two issues:
 1. No footsteps sound for CD-Rom version
 2. No footsteps sound for Floppy-Disc version.

 The fix actually solves the CD-Rom version but not the Floppy-Disc one.

 I am currently working on getting footsteps for the Floppy-Disc version,
 but I would like some help from the community.

 This is my research on that subject: the CD-Rom & Floppy-Disc versions do
 not run the same "code" (functions) when a Goblin is walking.

 The CD-Rom version is interpreted like this:

 `
 Debug: GOB01.TOT:00006540: opcodeFunc 0.0 [0x0.0x0] (o1_callSub)
 Debug: tot = "GOB01.TOT", offset = 6063
 Debug: GOB01.TOT:00006068: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: cmd = 0
 Debug: GOB01.TOT:00006246: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: cmd = 0
 Debug: GOB01.TOT:00006543: opcodeFunc 0.0 [0x0.0x0] (o1_callSub)
 Debug: tot = "GOB01.TOT", offset = 16653
 Debug: GOB01.TOT:00016658: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: cmd = 0
 Debug: GOB01.TOT:00016679: opcodeFunc 0.9 [0x0.0x9] (o2_assign)
 Debug: var parse = 23
 Debug: oper = 21

 // <------------- CALLSUB IS DONE HERE !

 Debug: GOB01.TOT:00016686: opcodeFunc 0.0 [0x0.0x0] (o1_callSub)
 Debug: tot = "GOB01.TOT", offset = 13676
 Debug: GOB01.TOT:00013681: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: GOB01.TOT:00013708: opcodeFunc 0.9 [0x0.0x9] (o2_assign)
 Debug: var parse = 23
 Debug: oper = 3346
 Debug: GOB01.TOT:00013716: opcodeFunc 0.9 [0x0.0x9] (o2_assign)
 Debug: var parse = 23
 Debug: oper = 3602
 Debug: GOB01.TOT:00013724: opcodeFunc 0.9 [0x0.0x9] (o2_assign)
 Debug: var parse = 23
 Debug: oper = 21
 Debug: GOB01.TOT:00013731: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: GOB01.TOT:00013750: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: GOB01.TOT:00013769: opcodeFunc 2.2 [0x2.0x2] (o1_speakerOn)  //
 o1_speakerOn is done -> footstep sound !!!!
 `

 As you can see the `o1_speakerOn` function is called in through a
 subroutine at `00016686`.

 In the Floppy-Disc version, we don't have this subroutine call:

 `
 Debug: gob01.TOT:00006282: opcodeFunc 0.0 [0x0.0x0] (o1_callSub)
 Debug: tot = "gob01.TOT", offset = 5965
 Debug: gob01.TOT:00005970: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: cmd = 0
 Debug: gob01.TOT:00006046: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: cmd = 0
 Debug: gob01.TOT:00006285: opcodeFunc 0.0 [0x0.0x0] (o1_callSub)
 Debug: tot = "gob01.TOT", offset = 16000
 Debug: gob01.TOT:00016005: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: cmd = 0
 Debug: gob01.TOT:00016026: opcodeFunc 0.9 [0x0.0x9] (o2_assign)
 Debug: var parse = 23
 Debug: oper = 21

 // <------ MISSING CALLSUB !!!!

 Debug: gob01.TOT:00016033: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: cmd = 0
 Debug: gob01.TOT:00016494: opcodeFunc 0.8 [0x0.0x8] (o1_if)
 Debug: cmd = 0
 Debug: gob01.TOT:00016526: opcodeFunc 2.5 [0x2.0x5] (o2_goblinFunc)
 Debug: opcodeGoblin 100 [0x64] (o2_handleGoblins)
 `

 If the footstep sound is really performed in the `o1_speakerOn` function
 as I expect, then I think there is a bug with the interpretation of the
 game **for the Floppy-Disc version only**.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15341#comment:9>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM