[Scummvm-tracker] [ScummVM :: Bugs] #15591: GOB: Goblins 3 - Latest save is not loaded

[ScummVM :: Bugs]

#15591: GOB: Goblins 3 - Latest save is not loaded
-------------------------------------+--------------------------
Reporter:  Jerome-Labbe-RedArtGames  |       Owner:  (none)
    Type:  defect                    |      Status:  new
Priority:  normal                    |   Component:  Engine: Gob
 Version:                            |  Resolution:
Keywords:                            |        Game:  Goblins 3
-------------------------------------+--------------------------
Comment (by Antonin-Carette-RedArtGames):

 I have found the issue: when saving, the GameHandler registers the slot
 index to save the game (in the example we name "0"), but the current
 `_reader` detains the old save state!

 Reloading the same save slot right after, the `_reader` is not recreated
 as the condition

 ```c
 if (!_reader || (_reader->getSlot() != ((uint32)slot))) { ... }
 ```

 if false.

 If you select another save, the slot is not the previous one, so the
 `_reader` will be recreated.

 I have two different solutions for that:
 1. Forget the condition to not recreate the `_reader` from scratch each
 time,
 2. Recreate the `_reader` right after a save.

 I would prefer the first solution personally.

 Also, looking at the code, I think the same mistake has been reproduced on
 other games like `Inca2` and all games that uses `v4` or `v6`.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15591#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM