[Scummvm-tracker] [ScummVM :: Bugs] #14918: Orion Burger: Game breaking bug at Test 2 hamster wheel

[ScummVM :: Bugs]

#14918: Orion Burger: Game breaking bug at Test 2 hamster wheel
------------------------+---------------------------
Reporter:  afreickmann  |       Owner:  (none)
    Type:  defect       |      Status:  new
Priority:  normal       |   Component:  Engine: M4
 Version:               |  Resolution:
Keywords:               |        Game:  Orion Burger
------------------------+---------------------------
Comment (by antoniou79):

 This reads similar to the crash I'm getting with the demo of the game at
 the hamster wheel. The crash still persists for me on release builds
 (--enable-release) on Linux and MinGW (msys2 MinGW-w64)

 (At one point I could also reproduce the door disappearing, but I could
 not reproduce it testing with today's build from master HEAD).

 I have tested today after the recent commits for M4 (and for this issue)
 but the crash still occurs. On Linux it prints a "segmentation fault" or a
 "free(): double free detected in tcache 2 Aborted (core dumped)" message
 to the command line when crashing.

 This matches with my notes in the previous bug ticket here:
 https://bugs.scummvm.org/ticket/14861#comment:4

 The -Waggressive-loop-optimizations warning message during the build might
 be relevant:
 {{{
 engines/m4/graphics/krn_pal.cpp: In function ‘void
 M4::krn_fade_to_grey(M4::RGB8*, int32, int32)’:
 engines/m4/graphics/krn_pal.cpp:189:37: warning: iteration 32 invokes
 undefined behavior [-Waggressive-loop-optimizations]
   189 |                 _GP(translation)[i] = (uint8)bestMatch;
 engines/m4/graphics/krn_pal.cpp:171:23: note: within this loop
   171 |         for (i = 0; i < 64; i++) {
       |                     ~~^~~~

 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14918#comment:4>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM