[Scummvm-tracker] [ScummVM :: Bugs] #14875: COMMON: Fallback detection of games happen even when there are exact matches

[ScummVM :: Bugs]

#14875: COMMON: Fallback detection of games happen even when there are exact
matches
-------------------------+---------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Common
 Version:                |  Resolution:
Keywords:                |        Game:
-------------------------+---------------------
Description changed by eriktorbjorn:

Old description:

> I don't know if this is a bug or a feature, though obviously I think it's
> a bug. When I try to add my copy of Orion Burger, I'm giving the
> following list of candidates:
>
> * Orion Burger (DOS/English)
> * Rex Nebular and the Cosmic Gender Bender (DOS/English) - Unknown
> variant
> * Return of the Phantom (DOS/English) - Unknown variant
> * Dragonsphere (DOS/English) - Unknown variant
> * Once Upon a Forest (DOS/English) - Unknown variant
>
> And the following console message:
>
> {{{
> The game in 'orionburger' seems to be an unknown game variant.
>
> Please report the following data to the ScummVM team at
> https://bugs.scummvm.org/ along with the name of the game you tried to
> add and
> its version, language, etc.:
>
> Matched game IDs for the mads engine: nebular, phantom, dragonsphere,
> forest
>
>   {"section1.hag", 0, "44773745949eee88762da4832dfb2517", 142360576},
> }}}
>
> However, the detection entry for Orion Burger ''does'' match my version
> perfectly. There shouldn't be any need for fallback detection.
>
> If I understand detection correctly, ScummVM will call detectGames() once
> for every engine. It will first look for exact matches, remove any
> pirated version it finds, and finally - if there are no exact matches -
> it will do fallback detection.
>
> But when it checks if there are any known games found, it that's only the
> known games **for that engine**, not the games it has found for other
> engines so far.
>
> Which probably means that if the engines had been listed in a different
> order, so that the M4 engine appeared last, it would have removed all the
> fallbacks in favor of the exact match. But now it finds an exact match,
> and later engines still get to add their fallback candidates.
>
> Which seems sub-optimal to me.

New description:

 I don't know if this is a bug or a feature, though obviously I think it's
 a bug. When I try to add my copy of Orion Burger, I'm giving the following
 list of candidates:

 * Orion Burger (DOS/English)
 * Rex Nebular and the Cosmic Gender Bender (DOS/English) - Unknown variant
 * Return of the Phantom (DOS/English) - Unknown variant
 * Dragonsphere (DOS/English) - Unknown variant
 * Once Upon a Forest (DOS/English) - Unknown variant

 And the following console message:

 {{{
 The game in 'orionburger' seems to be an unknown game variant.

 Please report the following data to the ScummVM team at
 https://bugs.scummvm.org/ along with the name of the game you tried to add
 and
 its version, language, etc.:

 Matched game IDs for the mads engine: nebular, phantom, dragonsphere,
 forest

   {"section1.hag", 0, "44773745949eee88762da4832dfb2517", 142360576},
 }}}

 However, the detection entry for Orion Burger ''does'' match my version
 perfectly. There shouldn't be any need for fallback detection.

 If I understand detection correctly, ScummVM will call detectGames() once
 for every engine. It will first look for exact matches, remove any pirated
 version it finds, and finally - if there are no exact matches - it will do
 fallback detection.

 But when it checks if there are any known games found, that's only the
 known games **for that engine**, not the games it has found for other
 engines so far. Which seems sub-optimal to me.

--
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14875#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM