[Scummvm-tracker] [ScummVM :: Bugs] #15241: AGI: Mixed-Up Mother Goose (DOS) - Segmentation fault on item return (ScummVM 2.8.1+)

[ScummVM :: Bugs]

#15241: AGI: Mixed-Up Mother Goose (DOS) - Segmentation fault on item return
(ScummVM 2.8.1+)
----------------------+------------------------------------
Reporter:  hugoarpin  |       Owner:  (none)
    Type:  defect     |      Status:  new
Priority:  normal     |   Component:  Engine: AGI
 Version:             |  Resolution:
Keywords:             |        Game:  Mixed-Up Mother Goose
----------------------+------------------------------------
Comment (by hugoarpin):

 Hi sluicebox,

 Thanks for the help! I have learnt of you through the impressive
 OneShortEye videos. I did not know you also worked on the AGI engine (on
 top of SCI), amazing!

 I have built the recent commits 3853dd99b5c yesterday and 0856bf2003e this
 morning, both of them segfault on my Arch Linux system.

 But interestingly, Jack Horner didn't crash (pie to boy in house at lower
 right), but Banbury Cross did (horse to town centre).

 So as you said, it seems to only affect certain rhymes. I will try to give
 you an exhaustive list of the crashes tonight (hoping that I will have
 enough free time).

 I have also built commit bc8550ce02a, which is the one you linked to
 inside the ticket #13820 and it also crashed at the line mentioned in my
 previous message (engines/agi/graphics.cpp:599 curColor =
 _activeScreen[offsetVisual++]).

 However, when I built the commit just before (8f2127e4184), the text box
 was a bit messed up because the refactor was not yet complete, but it did
 not segfault, so it seems that bc8550ce02a could be the cause.

 I hope the seemingly somewhat platform-specific nature of the bug will not
 be too difficult to hunt/fix! Linux can be such a pain sometimes...

 PS: I tried this game(s) because it showcased so many engine evolutions
 (AGI / SCI dithered EGA / SCI VGA talkie / SCI deluxe 640x480). But I must
 say that I found it quite charming and that it is still a beautiful game
 for young boys & girls nowadays IMO!
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15241#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM