[Scummvm-tracker] [ScummVM :: Bugs] #15243: Segfault switching to OpenGL

[ScummVM :: Bugs]

#15243: Segfault switching to OpenGL
------------------------+---------------------
Reporter:  scummvmuser  |       Owner:  (none)
    Type:  defect       |      Status:  new
Priority:  high         |   Component:  GUI
 Version:               |  Resolution:
Keywords:               |        Game:
------------------------+---------------------
Comment (by scummvmuser):

 I found that if the Options box is opened while in SDL mode and
 `--disable-aspect` was given to `configure`, then the Aspect checkbox is
 not there, but it looks like in OpenGL mode it is expected regardless (and
 is present if the Options are opened while in OpenGL mode.)
 I wonder whether that configure option should be made more properly
 effective, but in any case I mimicked nearby lines and did
 {{{
 diff --git a/gui/options.cpp b/gui/options.cpp
 index 1ae2bd3edcd..d1c33f373d0 100644
 --- a/gui/options.cpp
 +++ b/gui/options.cpp
 @@ -2033,6 +2033,8 @@ void OptionsDialog::setupGraphicsTab() {
                         rebuild();
                 } else if (!_stretchPopUp &&
 g_system->hasFeature(OSystem::kFeatureStretchMode)) {
                         rebuild();
 +               } else if (!_aspectCheckbox &&
 g_system->hasFeature(OSystem::kFeatureAspectRatioCorrection)) {
 +                       rebuild();
                 }
                 setGraphicSettingsState(_enableGraphicSettings);
         }
 }}}
 and I no longer crash. I don't know if this is fixing the problem in the
 right place...
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15243#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM