[Scummvm-tracker] [ScummVM :: Bugs] #15293: AGI: LSL1: Insufficient feedback when the same text box is repeated

[ScummVM :: Bugs]

#15293: AGI: LSL1: Insufficient feedback when the same text box is repeated
---------------------------------+-------------------------
Reporter:  eriktorbjorn          |      Owner:  (none)
    Type:  defect                |     Status:  new
Priority:  normal                |  Component:  Engine: AGI
 Version:                        |   Keywords:
    Game:  Leisure Suit Larry 1  |
---------------------------------+-------------------------
 When you give the whiskey to the drunk, the message "...my only
 posshhess... hhic!" is repeated three times.

 Unless you're in on the joke, you may think the game has locked up because
 nothing seems to happen when you press Enter to dismiss the text box. This
 is similar to the lottery messages in LSL2. The problem was fixed there,
 so maybe it can be fixed here as well even though it's a different engine?

 The quick-and-dirty fix might be something like this:

 {{{
 diff --git a/engines/agi/text.cpp b/engines/agi/text.cpp
 index 06773598849..eefbdc263cc 100644
 --- a/engines/agi/text.cpp
 +++ b/engines/agi/text.cpp
 @@ -558,6 +558,8 @@ void TextMgr::closeWindow() {
                 const int16 x = _messageState.backgroundPos_x;
                 const int16 y = MAX<int16>(0,
 _messageState.backgroundPos_y);
                 _gfx->render_Block(x, y,
 _messageState.backgroundSize_Width, _messageState.backgroundSize_Height);
 +               _gfx->updateScreen();
 +               _vm->_system->delayMillis(50);
         }
         _messageState.dialogue_Open = false;
         _messageState.window_Active = false;
 }}}

 With some appropriate comment, of course. But maybe there's a better way?

 (I just felt a tiny disturbance in the Force, as if a small handful of
 speedrunners suddenly cried out in terror and were suddenly silenced.)
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15293>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM