[Scummvm-tracker] [ScummVM :: Bugs] #15294: AGS: Frequent use of bitwise OR/ANDs instead of logical operators [upstream "bug"]

ScummVM :: Bugs trac at scummvm.org
Sat Jul 27 14:49:49 UTC 2024


#15294: AGS: Frequent use of bitwise OR/ANDs instead of logical operators [upstream
"bug"]
--------------------+--------------------------
Reporter:  RainRat  |       Owner:  (none)
    Type:  defect   |      Status:  new
Priority:  normal   |   Component:  Engine: AGS
 Version:           |  Resolution:
Keywords:           |        Game:
--------------------+--------------------------
Comment (by RainRat):

 If I find any more, I'll add them here, so they're in one place:

 Current:
 {{{
 int NewControl::mouseisinarea(int mx, int my) {
 [...]
         if ((mx > x) &(mx < x + wid) &(my > y) &(my < y + hit))
 }}}

 Expected:
 {{{
 int NewControl::mouseisinarea(int mx, int my) {
 [...]
         if ((mx > x) &&(mx < x + wid) &&(my > y) &&(my < y + hit))
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15294#comment:4>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list