[Scummvm-tracker] [ScummVM :: Bugs] #15162: Using the word "that" when talking to a character causes a segfault

[ScummVM :: Bugs]

#15162: Using the word "that" when talking to a character causes a segfault
---------------------+-------------------------------
Reporter:  benblank  |       Owner:  (none)
    Type:  defect    |      Status:  new
Priority:  normal    |   Component:  --Unset--
 Version:            |  Resolution:
Keywords:            |        Game:  Starship Titanic
---------------------+-------------------------------
Comment (by antoniou79):

 This does not happen only with the word "that".
 Other words that may cause this are "this" and "those" (but not "these").
 Also some words (like "this") seems to be treated in a special way with
 some bots so with those, the crash won't occur.

 I can see where the seg fault occurs (MSVC did not help there because, at
 least with my config, it does not crash, even though it does try to access
 a property or method of a non existing object).

 The crash seems to happen here:
 https://github.com/scummvm/scummvm/blob/718353f51218c0a66b820e0438ef15d6f702d919/engines/titanic/true_talk/tt_parser.cpp#L1210

 because for this case the _conceptP is a nullptr.

 But the cause for it should be rooted earlier in the execution, probably
 related to the process assigning a category to the word.

 That's to say, checking for nullptr at the crash point, fixes this
 specific crash, but I don't think it's the right solution.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15162#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM