[Scummvm-tracker] [ScummVM :: Bugs] #15222: SCI: PEPPER: The carrier pigeon is barely visible when flying to Penn Mansion

[ScummVM :: Bugs]

#15222: SCI: PEPPER: The carrier pigeon is barely visible when flying to Penn
Mansion
-------------------------+------------------------------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: SCI
 Version:                |  Resolution:
Keywords:                |        Game:  Pepper's Adventures in Time
-------------------------+------------------------------------------
Comment (by eriktorbjorn):

 The problem is probably in the way the pigeon graphics are scaled. If I
 force the graphics to be drawn at their actual size, like this:

 {{{
 diff --git a/engines/sci/graphics/animate.cpp
 b/engines/sci/graphics/animate.cpp
 index b7af374f173..97c1a57a643 100644
 --- a/engines/sci/graphics/animate.cpp
 +++ b/engines/sci/graphics/animate.cpp
 @@ -217,6 +217,7 @@ void GfxAnimate::makeSortedList(List *list) {
                 if (getSciVersion() >= SCI_VERSION_1_1) {
                         // Cel scaling
                         listEntry.scaleSignal =
 readSelectorValue(_s->_segMan, curObject, SELECTOR(scaleSignal));
 +                       listEntry.scaleSignal &= ~kScaleSignalDoScaling;
                         if (listEntry.scaleSignal & kScaleSignalDoScaling)
 {
                                 listEntry.scaleX =
 readSelectorValue(_s->_segMan, curObject, SELECTOR(scaleX));
                                 listEntry.scaleY =
 readSelectorValue(_s->_segMan, curObject, SELECTOR(scaleY));
 }}}

 The bird is drawn the entire flight:

 [[Image(scummvm-pepper-00020.png)]]

 Of course, that does ''not'' match the original.

 The problem is more likely to be in GfxView::drawScaled(). The bird is
 often scaled down to 0x2 or even 0x0 pixels.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15222#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM