[Scummvm-tracker] [ScummVM :: Bugs] #15233: SCI: PQ2: My Game Keeps Crashing

[ScummVM :: Bugs]

#15233: SCI: PQ2: My Game Keeps Crashing
-------------------------+-----------------------------
Reporter:  ArthurWalden  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: SCI
 Version:                |  Resolution:
Keywords:  pq2, crash    |        Game:  Police Quest 2
-------------------------+-----------------------------
Comment (by sluicebox <22204938+sluicebox@…>):

 In [changeset:"cf842571c2e150cafe051f1a5378465a4f3f39fe" cf842571]:
 {{{#!CommitTicketReference repository=""
 revision="cf842571c2e150cafe051f1a5378465a4f3f39fe"
 SCI: Fix SCI0 MIDI filtering when multiple stop events

 SCI0 MIDI filtering creates a new event stream, but it was generating
 malformed events when there were multiple stop events (status byte FC).
 This caused MidiParser_SCI::parseEvent to miss the stop event written by
 the filter code. The parser would continue reading and parsing out of
 bounds heap memory until crashing seemingly randomly.

 Now the filter always stops on the first stop event and always writes
 out its own stop event correctly.

 Fixes PQ2 airport music, bug #15233

 Thanks to @antoniou79 for triaging the bug report
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15233#comment:8>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM