[Scummvm-tracker] [ScummVM :: Bugs] #15146: DIRECTOR: Bad palette in The Dark Eye

[ScummVM :: Bugs]

#15146: DIRECTOR: Bad palette in The Dark Eye
-------------------------+------------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  --Unset--
 Version:                |  Resolution:
Keywords:                |        Game:
-------------------------+------------------------
Description changed by eriktorbjorn:

Old description:

> In The Dark Eye (v1.0/Windows/English), once the game starts the palette
> is messed up. See attached screenshot.
>
> This is a recent regression. Bisecting points to this commit:
>
> {{{
> bde3fe3f77bb201d4a90d3883a7be7c62435496e is the first bad commit
> commit bde3fe3f77bb201d4a90d3883a7be7c62435496e
> Author: Scott Percival <code at moral.net.au>
> Date:   Tue May 28 16:07:20 2024 +0800
>
>     DIRECTOR: Reset palette in use on movie switch
>
>     Previously if there was a movie switch, and the two movies used
>     different custom palettes with the same cast ID, there was no
>     mechanism to force a swap to the new palette.
>
>     Fixes palette glitches in Die Hexenakademie.
>
>  engines/director/castmember/palette.cpp |  9 ++++++++-
>  engines/director/castmember/palette.h   |  1 +
>  engines/director/graphics.cpp           | 28
> ++++++++++++++++++++++++++--
>  engines/director/window.cpp             |  1 +
>  4 files changed, 36 insertions(+), 3 deletions(-)
> }}}

New description:

 In The Dark Eye (v1.0/Windows/English), once the game starts the palette
 is messed up, like this:

 [[Image(scummvm-darkeye-win-00000.png)]]

 I've chosen this screenshot because it demonstrates that certain elements
 in the image may still have the correct palette. This is a recent
 regression. Bisecting points to this commit:

 {{{
 bde3fe3f77bb201d4a90d3883a7be7c62435496e is the first bad commit
 commit bde3fe3f77bb201d4a90d3883a7be7c62435496e
 Author: Scott Percival <code at moral.net.au>
 Date:   Tue May 28 16:07:20 2024 +0800

     DIRECTOR: Reset palette in use on movie switch

     Previously if there was a movie switch, and the two movies used
     different custom palettes with the same cast ID, there was no
     mechanism to force a swap to the new palette.

     Fixes palette glitches in Die Hexenakademie.

  engines/director/castmember/palette.cpp |  9 ++++++++-
  engines/director/castmember/palette.h   |  1 +
  engines/director/graphics.cpp           | 28 ++++++++++++++++++++++++++--
  engines/director/window.cpp             |  1 +
  4 files changed, 36 insertions(+), 3 deletions(-)
 }}}

--
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15146#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM