[Scummvm-tracker] [ScummVM :: Bugs] #15457: KQ7: Odd behavior for disabling subtitles

[ScummVM :: Bugs]

#15457: KQ7: Odd behavior for disabling subtitles
-----------------------+-----------------------------
Reporter:  antoniou79  |       Owner:  (none)
    Type:  defect      |      Status:  new
Priority:  normal      |   Component:  Engine: SCI
 Version:              |  Resolution:
Keywords:              |        Game:  King's Quest 7
-----------------------+-----------------------------
Comment (by eriktorbjorn):

 The version file of my copy of King's Quest VII says "2.00b". But I'm
 still leaning towards an error int he ScummVM options dialog. Let's try
 from a completely blank slate.

 I started ScummVM and changed the global audio settings to "Both". This is
 now my scummvm.ini:

 {{{
 [scummvm]
 gui_browser_native=true
 mute=false
 speech_volume=192
 native_mt32=false
 mt32_device=null
 confirm_exit=false
 gui_use_game_language=false
 gui_scale=100
 gui_return_to_launcher_at_exit=false
 gui_disable_fixed_font_scaling=false
 subtitles=true
 gm_device=auto
 sfx_volume=192
 music_volume=192
 autosave_period=300
 music_driver=auto
 opl_driver=auto
 aspect_ratio=true
 versioninfo=2.9.0git10472-gec1c846eaff
 speech_mute=false
 }}}

 I add the game (selecting the "DOS" version), but change the Audio
 settings to override the global settings so that I get "Speech" instead
 without subtitles. This is the entry I get for the game:

 {{{
 [kq7]
 description=King's Quest VII: The Princeless Bride (DOS/English)
 gmm_save_enabled=false
 extrapath=dists/engine-data/
 path=/path-to/kq7
 enable_video_upscale=true
 engineid=sci
 gameid=kq7
 language=en
 music_driver=auto
 platform=pc
 enable_hq_video=true
 opl_driver=auto
 speech_mute=false
 guioptions=sndLinkSpeechToSfx sndLinkMusicToSfx noAspect gameOptionA
 gameOptionD gameOptionI lang_English
 }}}

 Note that there is no `"subtitles"` setting in the entry.

 I _think_ what happens is that when the options dialog changes the
 settings, it checks if there is a setting specifically for the game and
 gets the default value (false). This is the same as what you're trying to
 save, so it doesn't think it necessary to explicitly write the setting to
 the file. When the engine checks the setting, it sees that there is no
 game-specific setting, so you get the global setting (true).

 If you change the game-specific setting to one where `"subtitles"` is
 true, the dialog _does_ see that it has changed and writes it to the file.
 Then when you change it back to voices only, the setting has once again
 changed, so it writes it to the file. Now everything works as expected.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15457#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM