[Scummvm-tracker] [ScummVM :: Bugs] #15162: TITANIC: Using the word "that" when talking to a character causes a segfault

[ScummVM :: Bugs]

#15162: TITANIC: Using the word "that" when talking to a character causes a
segfault
-------------------------------------------------+-------------------------
Reporter:  benblank                              |       Owner:
                                                 |  dreammaster
    Type:  defect                                |      Status:  closed
Priority:  blocker                               |   Component:  Engine:
                                                 |  Titanic
 Version:                                        |  Resolution:  fixed
Keywords:  crash, wc_pronoun, word, parser,      |        Game:  Starship
  this, those, that                              |  Titanic
-------------------------------------------------+-------------------------
Changes (by dreammaster):

 * owner:  (none) => dreammaster
 * resolution:   => fixed
 * status:  new => closed

Comment:

 I tried looking into the problem months ago, and I swear that I couldn't
 replicate the problem at the time. Maybe it's true what told me earlier,
 that MSVC is silently allowing dereferencing null pointers without
 throwing a wobbly. Anyway, when I added some explict asserts, I was
 finally able to replicate the problem. Then tracing through the TTparser
 code execution, I finally tracked down the issue properly. At the start of
 TTparser::checkForAction, it's meant to go into the block if !_conceptP,
 so one can be set up. But previously, it was only going into the block if
 one *was* set up, leading to the situation where a dummy _conceptP was
 never being set. I'm just committing a fix now.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15162#comment:7>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM