[Scummvm-tracker] [ScummVM :: Bugs] #15013: COMMON: Invalid save path leads to crash/debugger coming up

ScummVM :: Bugs trac at scummvm.org
Sat Nov 9 22:54:48 UTC 2024


#15013: COMMON: Invalid save path leads to crash/debugger coming up
------------------------------+---------------------
Reporter:  raziel-            |       Owner:  (none)
    Type:  defect             |      Status:  new
Priority:  blocker            |   Component:  Common
 Version:                     |  Resolution:
Keywords:  timestamps, crash  |        Game:
------------------------------+---------------------
Comment (by sev-):

 I have a clarifying question. How do you set the savepath? When it is done
 via GUI, then the following code is executed:

 `
                         Common::FSNode dir(browser.getResult());
                         if (dir.isWritable()) {
                                 _savePath->setLabel(dir.getPath());
                         } else {
                                 MessageDialog error(_("The chosen
 directory cannot be written to. Please select another one."));
                                 error.runModal();
                                 return;

 `

 E.g. the user is presented with a warning.

 If you set it directly in the scummvm.ini, first of all, you are shooting
 yourself in the foot.

 But well, what could be done is that we test that the path is not
 writeable at start of any engine and error out.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15013#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list