[Scummvm-tracker] [ScummVM :: Bugs] #15521: ENGINES: Some graphics settings for 2D games are ignored

[ScummVM :: Bugs]

#15521: ENGINES: Some graphics settings for 2D games are ignored
--------------------+----------------------
Reporter:  criezy   |      Owner:  (none)
    Type:  defect   |     Status:  new
Priority:  blocker  |  Component:  Graphics
 Version:           |   Keywords:
    Game:           |
--------------------+----------------------
 The pull request [https://github.com/scummvm/scummvm/pull/6252 ENGINES:
 Use common GFX code for 3D games] that was merged two days ago introduces
 a regression with all 2D games. Now filtering, scaler, and shader set in
 the game options are ignored.

 This happens because
 `g_system->hasFeature(OSystem::kFeatureOpenGLForGame)`, that is now
 checked in `initCommonGFX()` to skip some settings for 3D games, is
 actually always true with the SDL, Android, and iOS backends, even for 2D
 games. It indicates that the backend supports hardware-accelerated 3D
 games, not that the current one is such a game.
 See
 https://github.com/scummvm/scummvm/blob/master/backends/platform/sdl/sdl.cpp#L200-L205

 So those settings are now skipped for 2D game as well.

 I don't know how to properly test if a 3D game is running though. Maybe
 getFeatureState(OSystem::kFeatureOpenGLForGame) should return true for
 OpenGLSdlGraphics3dManager, iOSGraphics3dManager, and
 AndroidGraphics3dManager, which does not seem to be the case currently,
 and then here we could use getFeatureState() instead of hasFeature().
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15521>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM