[Scummvm-tracker] [ScummVM :: Bugs] #15353: SCUMM: MONKEY1 (Macintosh) Crash in saveLoadWithSerializer loading 2.8.0 saves on 2.9.0git

[ScummVM :: Bugs]

#15353: SCUMM: MONKEY1 (Macintosh) Crash in saveLoadWithSerializer loading 2.8.0
saves on 2.9.0git
----------------------------+-----------------------------
Reporter:  dwatteau         |      Owner:  (none)
    Type:  defect           |     Status:  new
Priority:  high             |  Component:  Engine: SCUMM
 Version:                   |   Keywords:  saves,macintosh
    Game:  Monkey Island 1  |
----------------------------+-----------------------------
 If I try loading one of my older saves (made with ScummVM 2.8.0) for
 Monkey1 Macintosh, on current ScummVM 2.9.0git HEAD, I always get the
 following crash:

 {{{
 (lldb) run
 User picked target 'monkey-mac' (engine ID 'scumm', game ID 'monkey')...
 Process 51726 stopped
 * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS
 (code=1, address=0x7ff7c017c8e0)
     frame #0: 0x0000000100004c1c
 scummvm`Common::BaseString<char>::c_str(this=0x00007ff7c017c8d8) const at
 str-base.h:173:50
    170                  return begin() + size();
    171          }
    172
 -> 173          inline const value_type *c_str() const { return _str; }
    174          inline uint size() const         { return _size; }
    175
    176          inline bool empty() const { return (_size == 0); }
 Target 0: (scummvm) stopped.
 (lldb) bt
 * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS
 (code=1, address=0x7ff7c017c8e0)
   * frame #0: 0x0000000100004c1c
 scummvm`Common::BaseString<char>::c_str(this=0x00007ff7c017c8d8) const at
 str-base.h:173:50
     frame #1: 0x00000001001670d3
 scummvm`Scumm::ScummEngine::saveLoadWithSerializer(this=0x00000001100d0000,
 s=0x00007ff7bfefcb20) at saveload.cpp:1973:35
     frame #2: 0x000000010016a391
 scummvm`Scumm::ScummEngine_v5::saveLoadWithSerializer(this=0x00000001100d0000,
 s=0x00007ff7bfefcb20) at saveload.cpp:2151:15
     frame #3: 0x000000010016289b
 scummvm`Scumm::ScummEngine::loadState(this=0x00000001100d0000, slot=2,
 compat=false, filename=0x00007ff7bfefcc40) at saveload.cpp:771:2
     frame #4: 0x00000001001621ed
 scummvm`Scumm::ScummEngine::loadState(this=0x00000001100d0000, slot=2,
 compat=false) at saveload.cpp:625:9
     frame #5: 0x00000001001b94b4
 scummvm`Scumm::ScummEngine::go(this=0x00000001100d0000) at
 scumm.cpp:2417:29
     frame #6: 0x00000001001bed42
 scummvm`Scumm::ScummEngine::run(this=0x00000001100d0000) at scumm.h:583:10
     frame #7: 0x000000010001e796
 scummvm`runGame(enginePlugin=0x0000600000221b80,
 system=0x0000000101a04df0, game=0x00007ff7bfefda00,
 meDescriptor=0x0000000000000000) at main.cpp:311:33
     frame #8: 0x000000010001c9a0 scummvm`::scummvm_main(argc=1,
 argv=0x00007ff7bfeff930) at main.cpp:796:13
     frame #9: 0x0000000100015dad scummvm`main(argc=1,
 argv=0x00007ff7bfeff930) at macosx-main.cpp:44:12
     frame #10: 0x0000000100df952e dyld`start + 462
 }}}

 I'm attaching two saves below.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15353>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM