[Scummvm-tracker] [ScummVM :: Bugs] #15379: ADL: HIRES5: Game unsolvable after loading savegame. Save state not properly restored?

[ScummVM :: Bugs]

#15379: ADL: HIRES5: Game unsolvable after loading savegame. Save state not
properly restored?
-------------------------------------------+-------------------------
Reporter:  eriktorbjorn                    |      Owner:  (none)
    Type:  defect                          |     Status:  new
Priority:  normal                          |  Component:  Engine: ADL
 Version:                                  |   Keywords:
    Game:  Hi-Res Adventure #5: Time Zone  |
-------------------------------------------+-------------------------
 English version of Time Zone, from the Roberta Williams Anthology.
 Current development version of ScummVM.

 After completing the first task for Robin Hood, I was told to retrieve a
 bag of money from the Sheriff's office. At this point I saved. When I went
 to the office, the bag wasn't there.

 I replayed that time zone again, without saving. This time the bag was
 there.

 I think what happens is this. When you complete the first task, it sets
 the picture for the room where the money is supposed to be:

 {{{
 IF
         ROOM == 28
         && SAID(*, *)
         && VARS[6] == 2
 THEN
         PRINT(75/YOU HAVE PROVEN YOUR BRAVERY AND SKILL!YOU ARE OFFICIALLY
 ONE OF ROBIN HOOD'S MERRY MEN. ROBIN HOOD NOW HAS A TASK FOR YOU TO DO.
 THERE IS A BAG OF MONEY IN THE BACK ROOM OF THE SHERIFF'S OFFICE. GET IT,
 AND BRING IT BACK TO ROBIN HOOD.)
         VARS[6] = 3
         SET_ROOM_PIC(32, 41)
 END
 }}}

 The savegame contains the picture of each room in every region. See
 `AdlEngine_v4::saveState()`.

 However, in `AdlEngine_v4::loadState()`, once the savegame has been loaded
 it calls `loadRegion()`, and I have a hunch that this overwrites the
 custom pictures with the default ones. Afterwards, it calls
 `restoreRoomState()` but that only seems to restore the room picture for
 the ''current'' room.

 I'm not sure how to fix this properly. I'm going to attach a savegame.
 From this, use the following commands:

 E. E. TALK ROBIN. YES. S. S. E. USE BOW. W. W.

 You have completed the first task. This is where I saved when I triggered
 the bug. From here.

 W. N. N. N. N. N. W. N. N. W. LOOK WINDOW.

 If you do it without saving/loading, the bag of money will be seen on the
 table. If you saved and restored, it will not.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15379>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM