[Scummvm-tracker] [ScummVM :: Bugs] #15375: SCI: SQ4 Korean text not rendered after refactor

ScummVM :: Bugs trac at scummvm.org
Sun Sep 22 15:30:17 UTC 2024


#15375: SCI: SQ4 Korean text not rendered after refactor
----------------------+----------------------------
Reporter:  sluicebox  |       Owner:  (none)
    Type:  defect     |      Status:  new
Priority:  normal     |   Component:  Engine: SCI
 Version:             |  Resolution:
Keywords:             |        Game:  Space Quest 4
----------------------+----------------------------
Comment (by athrxx):

 It would require an unusual amount of ugly hacking to support scrolling
 hires texts. I have worked on it to a point where it really made no sense
 to continue. It doesn't seem like a good idea to spam the code with KOR
 hacks, when it takes only 3 or 4 lines of code change to just restore the
 old state.

 The goal of totally getting rid of `_upscaledHires` cannot be achieved
 anyway. I have verified that SCI0 Mac really scales coordinates inside the
 engine drawing code and performs vector operations (like Bresenham line
 drawing) on these scaled coordinates. So it isn't possible to simply
 upscale this at a later point.

 Is it okay if I partially revert 3ce0915e584f7515513b73a6703a9ba246c1a9d4?
 And also the two (then obsolete) commits I made here as a fix.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15375#comment:9>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list