[Scummvm-tracker] [ScummVM :: Bugs] #15375: SCI: SQ4 Korean text not rendered after refactor

[ScummVM :: Bugs]

#15375: SCI: SQ4 Korean text not rendered after refactor
----------------------+----------------------------
Reporter:  sluicebox  |       Owner:  (none)
    Type:  defect     |      Status:  new
Priority:  normal     |   Component:  Engine: SCI
 Version:             |  Resolution:
Keywords:             |        Game:  Space Quest 4
----------------------+----------------------------
Comment (by athrxx):

 Replying to [comment:10 sluicebox]:
 > Whatever you think is best. I'm not really following the code changes
 that are going along with this. (That's often the case with the things you
 do, because they look hard!)
 >
 > Do you want to sit on it for a while in case you think of something
 else? None of this is urgent.
 >

 Yeah, that's probably the best idea. Maybe I can come up with something
 else during next week or so...

 > My main thing on these extras that weren't in the original, like RTL
 text or whatever, is that they should be factored out as much as possible
 from the already complicated genuine engine code by however one can. I
 believe that's your thing too, so my attitude is "whatever athrxx wants"
 =)
 >

 Yes, I would really like to factor out the upscale logic, although I have
 come to understand that for SCI0 Mac there is no chance, since the
 original interpreter really does have the modified vector drawing code in
 the engine.

 > (Unrelated but while you're in the graphics code, did you know that
 `_needsUnditheringPalette` isn't used? It generates a warning, but maybe
 you're going to use it later?)

 No, I didn't see any warning. But I think you're right. I am using the
 argument only in the constructor. Inside `remapTextColor()` I am just
 checking the `_textModePalette` instead. I'll remove the unneeded var...
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15375#comment:11>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM