[Scummvm-tracker] [ScummVM :: Bugs] #15849: SCUMM: INDY3: Unsupported IMuseDriver_Macintosh() game ID with indy3-steam-mac

[ScummVM :: Bugs]

#15849: SCUMM: INDY3: Unsupported IMuseDriver_Macintosh() game ID with indy3-steam-
mac
----------------------------+---------------------------
Reporter:  dwatteau         |      Owner:  (none)
    Type:  defect           |     Status:  new
Priority:  normal           |  Component:  Engine: SCUMM
 Version:                   |   Keywords:
    Game:  Indiana Jones 3  |
----------------------------+---------------------------
 On ScummVM 2.10.0git, trying to run the `Steam/Macintosh/English` release
 of Indy3 (i.e. the DOS VGA release, ported to 32-bit macOS through Steam)
 fails with the following fatal error:

 {{{
 IMuseDriver_Macintosh(): Unsupported game ID 3!
 }}}

 The following diff appears to fix this:

 {{{
 diff --git a/engines/scumm/metaengine.cpp b/engines/scumm/metaengine.cpp
 index 288b8993d4b..37da39ebf50 100644
 --- a/engines/scumm/metaengine.cpp
 +++ b/engines/scumm/metaengine.cpp
 @@ -444,7 +444,7 @@ Common::Error ScummMetaEngine::createInstance(OSystem
 *syst, Engine **engine,
         // TODO: Maybe allow the null driver, too?
         if (res.game.platform == Common::kPlatformFMTowns &&
 res.game.version == 3)
                 res.game.midi = MDT_TOWNS;
 -       else if (res.game.platform == Common::kPlatformMacintosh &&
 res.game.version < 7 && res.game.heversion == 0)
 +       else if (res.game.platform == Common::kPlatformMacintosh &&
 res.game.version < 7 && res.game.heversion == 0 && res.extra &&
 strcmp(res.extra, "Steam") != 0)
                 res.game.midi = MDT_MACINTOSH;

         // Finally, we have massaged the GameDescriptor to our
 satisfaction, and can
 }}}

 But since there are already various checks for the `"Steam"` and
 `Common::kPlatformMacintosh` case in the engine setup code, but also there
 is this "`internally we force the platform to DOS`" part inside
 `ScummEngine::init()`, I'd rather have someone double check it's OK.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15849>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM