[Scummvm-tracker] [ScummVM :: Bugs] #15849: SCUMM: INDY3: Unsupported IMuseDriver_Macintosh() game ID with indy3-steam-mac

[ScummVM :: Bugs]

#15849: SCUMM: INDY3: Unsupported IMuseDriver_Macintosh() game ID with indy3-steam-
mac
---------------------+------------------------------
Reporter:  dwatteau  |       Owner:  (none)
    Type:  defect    |      Status:  new
Priority:  normal    |   Component:  Engine: SCUMM
 Version:            |  Resolution:
Keywords:            |        Game:  Indiana Jones 3
---------------------+------------------------------
Comment (by dwatteau):

 Replying to [comment:1 athrxx]:
 > I have no way of testing any such Steam Mac version, but maybe the code
 line in ScummEngine::init() that would change the platform to kPlatformDOS
 is not reached in INDY3?

 The `ScummEngine::init()` check succeeds, but it only resets the platform,
 not the midi driver. `ScummMetaEngine::createInstance()` is called first,
 so at this point `res.game.platform == Common::kPlatformMacintosh` would
 still evaluate to true there, thus setting `MDT_MACINTOSH` anyway.

 Replying to [comment:2 eriktorbjorn]
 > [...]
 > Perhaps this is the correct way of fixing it?
 > [...]

 Thanks, either is fine to me. I was wondering which approach felt cleaner.
 This one puts all the reset logic in the same place, but duplicates
 `MDT_PCSPK | MDT_PCJR | MDT_CMS | MDT_ADLIB` from the detection tables.
 I'm not sure it's such an issue, though.

 Anyway, I can commit any preferred approach if necessary. Thanks!
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15849#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM