[Scummvm-tracker] [ScummVM :: Bugs] #15857: SCI: GK1 Floppy lockup after phone rings on day 5 (was: SCI: Gabriel Knight Sins of the Fathers Problems)

[ScummVM :: Bugs]

#15857: SCI: GK1 Floppy lockup after phone rings on day 5
---------------------+-------------------------------
Reporter:  Mesandro  |       Owner:  sluicebox
    Type:  defect    |      Status:  closed
Priority:  normal    |   Component:  Engine: SCI
 Version:            |  Resolution:  fixed
Keywords:  original  |        Game:  Gabriel Knight 1
---------------------+-------------------------------
Changes (by sluicebox):

 * keywords:   => original
 * owner:  (none) => sluicebox
 * resolution:   => fixed
 * status:  new => closed
 * summary:  SCI: Gabriel Knight Sins of the Fathers Problems => SCI: GK1
     Floppy lockup after phone rings on day 5

Comment:

 Fixed in 48c95e3797d058dd19d9507044eb0e295eac766b

 I believe this is the first time this script bug has ever been fully
 understood and fixed.

 Our previous script patch used the NRS technique (change the 3 cycle delay
 to a 6 tick delay), but that doesn't work on floppy versions at certain
 game speed settings.

 Here In The Future, we have the tools to figure out the underlying script
 conflict, so I fixed that instead. The new patch does not alter delays or
 depend on any timing. This should fix all versions, and it's compatible
 with NRS patches.

 I'm closing this ticket as fixed, but you can create a new one with just
 the sound stuff if you want. Feel free to copy and paste, it's just that
 it gets confusing if different issues are mixed together.

 Thanks again for reporting!
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15857#comment:11>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM