[Scummvm-tracker] [ScummVM :: Bugs] #14853: COMMON: Rework path handling causes performance regression

[ScummVM :: Bugs]

#14853: COMMON: Rework path handling causes performance regression
-----------------------------------+----------------------------
Reporter:  mikrosk                 |       Owner:  lephilousophe
    Type:  defect                  |      Status:  pending
Priority:  normal                  |   Component:  Common
 Version:                          |  Resolution:  fixed
Keywords:  performance,regression  |        Game:
-----------------------------------+----------------------------
Comment (by i30817):

 Sorry to bug you but since the bug reporter is complaining about scan
 speed.

 Scummvm scans much much faster if you scan from the command line (it also
 has less false positives in games that falsely scan a inside dir as
 another version of the game).

 The reason is that the command line isn't recursive, so it just checks the
 top level of the directory given and adds the game or not.

 Since I'm in Linux, I can easily automate this for all immediate subdirs
 in multiple directories like this in the cmd line:

 rm -f add.log
 find ScummVM ScummVM_Text/ ScummVM_AGS/ -mindepth 1 -maxdepth 1 -type d
 -exec echo "{}" >> add.log \; -exec scummvm -a -p"{}"

 the log file is for if you want to check what games aren't being added in
 the dirs given (usually because they aren't at the top level dir to be
 scanned, but sometimes scummvm problems show like the bug I opened about
 discworld noir and director noir).

 Strangely adding games this way tends to add more games even if they don't
 have the checksums in scummvm. The reason is that adding this way, unlike
 the gui, will not repeat gameids. And unknown games in the same engine
 have the same Id (eg: 'Unknown Adventure Game Studio game'). Instead,
 after the first, it will add the first possibility of the fallbacks (the
 thing you see when you add a unknown checksum game). Since those
 possibilities are checked\added by signature files filenames, that one is
 usually right.


 In short, it saves a LOT of time.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/14853#comment:6>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM