[Scummvm-tracker] [ScummVM :: Bugs] #15754: Testbed: Test for file with trailing dot fails

[ScummVM :: Bugs]

#15754: Testbed: Test for file with trailing dot fails
----------------------+--------------------
Reporter:  chkuendig  |      Owner:  (none)
    Type:  defect     |     Status:  new
Priority:  normal     |  Component:  Common
 Version:             |   Keywords:
    Game:             |
----------------------+--------------------
 In testbed there's a test which seems to be failing:

 There's a test to read a file called "file." without passing the extra
 trailing dot:

 test file reading -
 [https://github.com/scummvm/scummvm/blob/e301905875acf2879f75d7b63875ea182000cfdd/engines/testbed/fs.cpp#L73
 fs.cpp#L73]
 file creation -
 [https://github.com/scummvm/scummvm/blob/e301905875acf2879f75d7b63875ea182000cfdd/dists
 /engine-data/create-testbed-data.sh#L43 create-testbed-data.sh#L43]

  I think there was a workaround for this for some circumstances
 ([https://github.com/scummvm/scummvm/commit/dd505ff6aebbe3f321d8bbebabc32a471c2ac0c8
 dd505ff6aebbe3f321d8bbebabc32a471c2ac0c8]) but I don't think this works
 generally when accessing files this way.


 Looking at the current code, this check is done in two places in
 [https://github.com/scummvm/scummvm/blob/master/common/file.cpp file.cpp],
 presumably File::open is the one that should handle this. When running
 testbed with debuglevel 8, I don't get the "Opening hashed:" output, so
 presumably this isn't running through that path at all: (I tested it on
 macos nightly master)

 {{{
 Info! Executing Test: ReadingFile
 FSDirectory::createReadStreamForMember('file.txt') ->
 '<redacted>/testbed/test1/file.txt'
 Message Extracted from test1/file.txt : It works!
 FSDirectory::createReadStreamForMember('file.txt') ->
 '<redacted>/testbed/test1/file.txt'
 Message Extracted from test1/file.txt : It works!
 FSDirectory::createReadStreamForMember('FILE.TXT') ->
 '<redacted>/testbed/test1/file.txt'
 Message Extracted from test1/FILE.TXT : It works!
 FSDirectory::createReadStreamForMember('File.txt') ->
 '<redacted>/testbed/Test2/File.txt'
 Message Extracted from Test2/File.txt : It works!
 FSDirectory::createReadStreamForMember('file.txt') ->
 '<redacted>/testbed/Test2/File.txt'
 Message Extracted from Test2/file.txt : It works!
 FSDirectory::createReadStreamForMember('FILE.TXT') ->
 '<redacted>/testbed/Test2/File.txt'
 Message Extracted from Test2/FILE.TXT : It works!
 FSDirectory::createReadStreamForMember('FILE.txt') ->
 '<redacted>/testbed/TEST3/FILE.txt'
 Message Extracted from TEST3/FILE.txt : It works!
 FSDirectory::createReadStreamForMember('file.txt') ->
 '<redacted>/testbed/TEST3/FILE.txt'
 Message Extracted from TEST3/file.txt : It works!
 FSDirectory::createReadStreamForMember('FILE.TXT') ->
 '<redacted>/testbed/TEST3/FILE.txt'
 Message Extracted from TEST3/FILE.TXT : It works!
 FSDirectory::createReadStreamForMember('fILe.txt') ->
 '<redacted>/testbed/tEST4/fILe.txt'
 Message Extracted from tEST4/fILe.txt : It works!
 FSDirectory::createReadStreamForMember('file.txt') ->
 '<redacted>/testbed/tEST4/fILe.txt'
 Message Extracted from tEST4/file.txt : It works!
 FSDirectory::createReadStreamForMember('FILE.TXT') ->
 '<redacted>/testbed/tEST4/fILe.txt'
 Message Extracted from tEST4/FILE.TXT : It works!
 Can't open game file for reading
 Reading from test5/file failed
 Can't open game file for reading
 Reading from test5/file failed
 Can't open game file for reading
 Reading from TEST5/FILE failed
 Failed 3 out of 15
 Result: Failed
 Info! Executing Test: WritingFile
 Data written and read correctly

 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15754>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM