[Scummvm-tracker] [ScummVM :: Bugs] #15674: ANDROID: Missing Game Options only for ARMV7

[ScummVM :: Bugs]

#15674: ANDROID: Missing Game Options only for ARMV7
------------------------+----------------------------
Reporter:  RogerW123    |       Owner:  (none)
    Type:  defect       |      Status:  new
Priority:  normal       |   Component:  GUI
 Version:               |  Resolution:
Keywords:  Android SCI  |        Game:  Space Quest 3
------------------------+----------------------------
Comment (by antoniou79):

 The above code ultimately calls this line:
 https://github.com/scummvm/scummvm/blob/4c3db038488e717268298eab88dd1811c91515b8/common
 /str-base.cpp#L1147

 It seems that the implementation of the memchr() method is not doing well
 when searching for (signed) char values which are "negative", ie. larger
 than 127.

 A tentative fix that works is to change the above line (and probably the
 similar line in the previous method as well) to:

 {{{
 return static_cast<char *>(memchr(ptr, 0xff & c, count));
 }}}

 However, we have many other (direct) calls to memchr() in our codebase
 which may also get the bug but won't get the fix, and also I am unsure
 that the fix is portable/future proof.

 So, I am not sure how to proceed with this.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15674#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM